Add hardware support for Lenovo LOQ 15aph8 #1206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janwinkler1
force-pushed
the
lenovo-loq-15aph8
branch
from
f014c36 to
ddeb41e
Compare
Mic92
reviewed
Oct 31, 2024
Mic92
reviewed
Oct 31, 2024
Mic92
reviewed
Oct 31, 2024
|
Please undraft if you are done with it. |
|
ty for your review.
will do! |
janwinkler1
force-pushed
the
lenovo-loq-15aph8
branch
2 times, most recently
from
3ded672 to
829cfb2
Compare
janwinkler1
force-pushed
the
lenovo-loq-15aph8
branch
from
829cfb2 to
50e35e3
Compare
Mic92
reviewed
Nov 12, 2024
Mic92
reviewed
Nov 12, 2024
| hardware.nvidia.modesetting.enable = lib.mkDefault true; | ||
| services.thermald.enable = lib.mkDefault true; | ||
|
|
||
| # These will merge with user settings, so no mkDefault needed |
There was a problem hiding this comment.
How does it merge with user settings? As far as I can see this requires 'lib.mkForce', no?
LucasFA
reviewed
Nov 17, 2024
|
|
||
| # Power management - using mkDefault as these can be overridden | ||
| hardware.nvidia.powerManagement.enable = lib.mkDefault true; | ||
| hardware.nvidia.modesetting.enable = lib.mkDefault true; |
There was a problem hiding this comment.
IIUC the nvidia.modesetting line is implied by the call to gpu/nvidia/ada-lovelace, as it calls gpu/nvidia, containing this same line.
(Notably the mentioned PR there is already merged)
Mic92
reviewed
Dec 1, 2024
|
|
||
| # Power management - using mkDefault as these can be overridden | ||
| hardware.nvidia.powerManagement.enable = lib.mkDefault true; | ||
| hardware.nvidia.modesetting.enable = lib.mkDefault true; |
There was a problem hiding this comment.
Suggested change
| hardware.nvidia.modesetting.enable = lib.mkDefault true; |
|
@janwinkler1 are you still working on this? |
|
hi @Mic92, sorry maybe we can close this. currently i do not have access to that hardware anymore (personal reasons). could reopen once the situation changes. wdyt? |
|
Let's do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input